fix(rename): skip stateless objects in PathsGenerator to prevent panic [PSGO-233] by Matovidlo · Pull Request #2591 · keboola/keboola-as-code

Matovidlo · 2026-04-28T12:03:53Z

Summary

Root cause: PathsGenerator.doUpdate calls objectState.LocalOrRemoteState() unconditionally, which panics when a manifest entry exists for a config that has neither local nor remote state. This happens when an orphaned scheduler config remains in the manifest after its target orchestrator was deleted — the state entry is created from the manifest but never populated with actual data from either local files or the remote API.
Crash location: internal/pkg/model/objectstate.go:265 → LocalOrRemoteState() → called from internal/pkg/state/local/paths.go:79 → PathsGenerator.doUpdate → internal/pkg/plan/rename/rename.go → rename.NewPlan → sync/pull
Why CI passes but local pull crashes: CI runs always start from an empty git repository (no pre-existing manifest), so there are no stale entries. Client machines have an existing manifest that accumulated the orphaned scheduler entry.

Changes

paths.go: Added two guards to doUpdate:
1. Return early when the object itself has neither local nor remote state (prevents LocalOrRemoteState() panic).
2. Return early after a recursive parent update when the parent is also stateless (prevents path resolution on an unresolvable parent).
plan_test.go: New test TestRenameAllPlan_StatelessObjectSkipped injects a stateless ConfigState into a loaded state and asserts NewPlan returns without error and excludes the orphan from rename actions.

Relation to previous fixes

PR #2580 fixed the naming registry collision. PR #2585 fixed the manifest SetRecords fail-fast and orphaned-scheduler handling in push/diff. This PR fixes the remaining crash path that triggers during kbc pull when the rename plan builder encounters the stateless state entry that those earlier fixes may not have fully cleaned up.

Test plan

go test -race ./internal/pkg/plan/rename/... -run TestRenameAllPlan
go test -race ./internal/pkg/state/local/...
Manual: kbc pull on a project with an orphaned scheduler config in the local manifest — should complete without crashing

Fixes PSGO-233 / SUPPORT-15941 (follow-up crash after #2585)

🤖 Generated with Claude Code

linear · 2026-04-28T12:03:57Z

PSGO-233 SUPPORT-15941 Problem with Keboola CLI in DevOps process - SLSP

Copilot

Pull request overview

Prevents kbc pull / rename-plan generation from panicking when the local state contains manifest-only (“stateless”) object entries (no local files and no remote API object), which can happen with orphaned scheduler configs.

Changes:

Add guards in PathsGenerator.doUpdate to skip stateless objects (and stateless parents) to avoid LocalOrRemoteState() panics.
Add a rename plan unit test intended to ensure stateless entries don’t break NewPlan.
Add an e2e CLI fixture that reproduces pull --force with an orphaned scheduler record plus a rename scenario.

Reviewed changes

Copilot reviewed 14 out of 22 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
internal/pkg/state/local/paths.go	Skip stateless objects/parents during path generation to prevent `LocalOrRemoteState()` panic.
internal/pkg/plan/rename/plan_test.go	Adds a unit test around stateless entries during rename plan creation.
test/cli/pull/pull-force-orphaned-scheduler-with-rename/args	New CLI e2e test arguments for `pull --force`.
test/cli/pull/pull-force-orphaned-scheduler-with-rename/expected-code	Expected exit code for the new CLI fixture.
test/cli/pull/pull-force-orphaned-scheduler-with-rename/expected-stderr	Expected warning output for manifest load warnings.
test/cli/pull/pull-force-orphaned-scheduler-with-rename/expected-stdout	Expected plan + rename output for the new CLI fixture.
test/cli/pull/pull-force-orphaned-scheduler-with-rename/initial-state.json	Initial remote state fixture for the new CLI test.
test/cli/pull/pull-force-orphaned-scheduler-with-rename/in/.keboola/manifest.json	Input manifest containing an orphaned scheduler config and a wrongly named config.
test/cli/pull/pull-force-orphaned-scheduler-with-rename/in/description.md	Input repository description fixture.
test/cli/pull/pull-force-orphaned-scheduler-with-rename/in/main/description.md	Input main-branch description fixture.
test/cli/pull/pull-force-orphaned-scheduler-with-rename/in/main/extractor/ex-generic-v2/wrong-name/config.json	Input config content fixture (pre-rename).
test/cli/pull/pull-force-orphaned-scheduler-with-rename/in/main/extractor/ex-generic-v2/wrong-name/description.md	Input config description fixture (pre-rename).
test/cli/pull/pull-force-orphaned-scheduler-with-rename/in/main/extractor/ex-generic-v2/wrong-name/meta.json	Input config metadata fixture (pre-rename).
test/cli/pull/pull-force-orphaned-scheduler-with-rename/in/main/meta.json	Input branch metadata fixture.
test/cli/pull/pull-force-orphaned-scheduler-with-rename/out/.keboola/manifest.json	Expected cleaned manifest after pull (orphan removed, renamed paths).
test/cli/pull/pull-force-orphaned-scheduler-with-rename/out/.keboola/project.json	Expected project metadata after pull.
test/cli/pull/pull-force-orphaned-scheduler-with-rename/out/description.md	Expected repository description output fixture.
test/cli/pull/pull-force-orphaned-scheduler-with-rename/out/main/description.md	Expected main-branch description output fixture.
test/cli/pull/pull-force-orphaned-scheduler-with-rename/out/main/extractor/ex-generic-v2/empty/config.json	Expected config content output fixture (post-rename).
test/cli/pull/pull-force-orphaned-scheduler-with-rename/out/main/extractor/ex-generic-v2/empty/description.md	Expected config description output fixture (post-rename).
test/cli/pull/pull-force-orphaned-scheduler-with-rename/out/main/extractor/ex-generic-v2/empty/meta.json	Expected config metadata output fixture (post-rename).
test/cli/pull/pull-force-orphaned-scheduler-with-rename/out/main/meta.json	Expected branch metadata output fixture.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

hosekpeter

Nit (out of scope):TestRenameAllPlan lines 51-59 action.Manifest = nil is set twice here. Could be cleaned up while we're here.

When a manifest entry exists for a config that has neither local nor remote state (e.g. an orphaned scheduler config after its target orchestrator was deleted), PathsGenerator.doUpdate called LocalOrRemoteState() which panicked unconditionally. Two guards added to doUpdate: 1. Skip the object itself when both HasLocalState and HasRemoteState are false. 2. Skip the object when its parent is stateless, since a valid path cannot be resolved without a resolved parent. Reproduces the crash in PSGO-233 / SUPPORT-15941 where kbc pull panicked on "object Local or Remote state must be set" for clients with an existing local manifest containing an orphaned scheduler entry. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Regression test for PSGO-233: verifies that kbc pull --force succeeds when the manifest contains an orphaned scheduler (fake ID, no local files, not in remote) AND a config exists at a wrong path that needs to be renamed. Previously PathsGenerator.doUpdate could panic on stateless objects encountered during the rename plan. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

romanbracinik

ok fixol by som len ten test este

Remove "Ignoring invalid local state." — the orphaned scheduler "456" is removed by SetRecords at manifest-load time (stderr warning only), so no localErr is produced and the stdout message is not printed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

romanbracinik

👌

Matovidlo marked this pull request as ready for review April 29, 2026 06:10

Matovidlo requested a review from jachym-tousek-keboola as a code owner April 29, 2026 06:10

Copilot AI review requested due to automatic review settings April 29, 2026 06:10

Matovidlo requested a review from hosekpeter as a code owner April 29, 2026 06:10

Copilot started reviewing on behalf of Matovidlo April 29, 2026 06:10 View session

Copilot AI reviewed Apr 29, 2026

View reviewed changes

Comment thread internal/pkg/state/local/paths.go

Comment thread internal/pkg/state/local/paths.go

Comment thread internal/pkg/plan/rename/plan_test.go Outdated

hosekpeter reviewed Apr 29, 2026

View reviewed changes

Comment thread internal/pkg/plan/rename/plan_test.go Outdated

Comment thread internal/pkg/plan/rename/plan_test.go Outdated

Matovidlo and others added 2 commits April 29, 2026 12:51

Matovidlo force-pushed the mvasko/PSGO-233/fix-rename-plan-stateless-panic branch from 5bcbce0 to 4329212 Compare April 29, 2026 10:52

Matovidlo requested review from hosekpeter and romanbracinik April 29, 2026 11:56

romanbracinik requested changes Apr 30, 2026

View reviewed changes

Comment thread internal/pkg/plan/rename/plan_test.go

Matovidlo force-pushed the mvasko/PSGO-233/fix-rename-plan-stateless-panic branch from 4329212 to c6695db Compare April 30, 2026 16:02

romanbracinik approved these changes Apr 30, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(rename): skip stateless objects in PathsGenerator to prevent panic [PSGO-233]#2591

fix(rename): skip stateless objects in PathsGenerator to prevent panic [PSGO-233]#2591
Matovidlo wants to merge 3 commits intomainfrom
mvasko/PSGO-233/fix-rename-plan-stateless-panic

Matovidlo commented Apr 28, 2026

Uh oh!

linear Bot commented Apr 28, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hosekpeter left a comment

Uh oh!

Uh oh!

Uh oh!

romanbracinik left a comment

Uh oh!

Uh oh!

romanbracinik left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Matovidlo commented Apr 28, 2026

Summary

Changes

Relation to previous fixes

Test plan

Uh oh!

linear Bot commented Apr 28, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hosekpeter left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

romanbracinik left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

romanbracinik left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants